lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 10 Sep 2021 17:45:17 +0800
From:   kernel test robot <>
To:     Xu Wang <>,
Subject: Re: [PATCH v2] blk-zoned: Remove needless request_queue NULL pointer

Hi Xu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on block/for-next]
[also build test ERROR on v5.14 next-20210910]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: for-next
config: microblaze-randconfig-r023-20210910 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add linux-review
        git fetch --no-tags linux-review Xu-Wang/blk-zoned-Remove-needless-request_queue-NULL-pointer-checks/20210910-144721
        git checkout bc1beb73948b721209a36db7693ed7a621037757
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

   block/blk-zoned.c: In function 'blkdev_report_zones_ioctl':
>> block/blk-zoned.c:349:35: error: implicit declaration of function 'dev_get_queue'; did you mean 'bdev_get_queue'? [-Werror=implicit-function-declaration]
     349 |         struct request_queue *q = dev_get_queue(bdev);
         |                                   ^~~~~~~~~~~~~
         |                                   bdev_get_queue
>> block/blk-zoned.c:349:35: error: initialization of 'struct request_queue *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
   cc1: all warnings being treated as errors

vim +349 block/blk-zoned.c

   340	/*
   341	 * BLKREPORTZONE ioctl processing.
   342	 * Called from blkdev_ioctl.
   343	 */
   344	int blkdev_report_zones_ioctl(struct block_device *bdev, fmode_t mode,
   345				      unsigned int cmd, unsigned long arg)
   346	{
   347		void __user *argp = (void __user *)arg;
   348		struct zone_report_args args;
 > 349		struct request_queue *q = dev_get_queue(bdev);
   350		struct blk_zone_report rep;
   351		int ret;
   353		if (!argp)
   354			return -EINVAL;
   356		if (!blk_queue_is_zoned(q))
   357			return -ENOTTY;
   359		if (copy_from_user(&rep, argp, sizeof(struct blk_zone_report)))
   360			return -EFAULT;
   362		if (!rep.nr_zones)
   363			return -EINVAL;
   365		args.zones = argp + sizeof(struct blk_zone_report);
   366		ret = blkdev_report_zones(bdev, rep.sector, rep.nr_zones,
   367					  blkdev_copy_zone_to_user, &args);
   368		if (ret < 0)
   369			return ret;
   371		rep.nr_zones = ret;
   372		rep.flags = BLK_ZONE_REP_CAPACITY;
   373		if (copy_to_user(argp, &rep, sizeof(struct blk_zone_report)))
   374			return -EFAULT;
   375		return 0;
   376	}

0-DAY CI Kernel Test Service, Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (35188 bytes)

Powered by blists - more mailing lists