linux-kernel - [PATCH] Makefile: 'Promote' -Wunused-but-set-variable to W=3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Sep 2021 16:29:05 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     masahiroy@...nel.org
Cc:     linux-kernel@...r.kernel.org, nathan@...nel.org,
        ndesaulniers@...gle.com, x86@...nel.org,
        linux-toolchains@...r.kernel.org
Subject: [PATCH] Makefile: 'Promote' -Wunused-but-set-variable to W=3


Upgrade -Wunused-but-set-variable to W=3 to avoid the build robots
sending endless spam for this garbage warning.

By promoting it to W=3 the robots will no longer report it and people
will no longer attempt to fix them by making the code worse.

Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
---
diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index d53825503874..6686cc587d3b 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -28,7 +28,6 @@ KBUILD_CFLAGS += -Wmissing-format-attribute
 KBUILD_CFLAGS += -Wmissing-prototypes
 KBUILD_CFLAGS += -Wold-style-definition
 KBUILD_CFLAGS += -Wmissing-include-dirs
-KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable)
 KBUILD_CFLAGS += $(call cc-option, -Wunused-const-variable)
 KBUILD_CFLAGS += $(call cc-option, -Wpacked-not-aligned)
 KBUILD_CFLAGS += $(call cc-option, -Wstringop-truncation)
@@ -88,6 +87,7 @@ KBUILD_CFLAGS += -Wredundant-decls
 KBUILD_CFLAGS += -Wsign-compare
 KBUILD_CFLAGS += -Wswitch-default
 KBUILD_CFLAGS += $(call cc-option, -Wpacked-bitfield-compat)
+KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable)
 
 KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN3