linux-kernel - Re: [PATCH 19/22] soc: sunxi: mbus: Add A31 ISP compatibles to the list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <208239ba-01b1-451e-6030-894bd25770c3@sholland.org>
Date:   Fri, 10 Sep 2021 21:36:46 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cc:     Yong Deng <yong.deng@...ewell.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Helen Koike <helen.koike@...labora.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-clk@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 19/22] soc: sunxi: mbus: Add A31 ISP compatibles to the
 list

On 9/10/21 1:41 PM, Paul Kocialkowski wrote:
> The A31 ISP sits on the mbus and requires the usual bus address
> adaptation. Add its compatibles to the list.

My understanding is that this driver only exists to work around old DT
bindings where the interconnects/interconnect-names = "dma-mem"
properties are not required (and so they are historically missing from
the device trees).

For new bindings, it would be better to use those properties and not add
to this list.

Regards,
Samuel

> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> ---
>  drivers/soc/sunxi/sunxi_mbus.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c
> index d90e4a264b6f..7f0079ea30b1 100644
> --- a/drivers/soc/sunxi/sunxi_mbus.c
> +++ b/drivers/soc/sunxi/sunxi_mbus.c
> @@ -37,6 +37,7 @@ static const char * const sunxi_mbus_devices[] = {
>  	"allwinner,sun5i-a13-video-engine",
>  	"allwinner,sun6i-a31-csi",
>  	"allwinner,sun6i-a31-display-backend",
> +	"allwinner,sun6i-a31-isp",
>  	"allwinner,sun7i-a20-csi0",
>  	"allwinner,sun7i-a20-display-backend",
>  	"allwinner,sun7i-a20-display-frontend",
> @@ -50,6 +51,7 @@ static const char * const sunxi_mbus_devices[] = {
>  	"allwinner,sun8i-h3-csi",
>  	"allwinner,sun8i-h3-video-engine",
>  	"allwinner,sun8i-v3s-csi",
> +	"allwinner,sun8i-v3s-isp",
>  	"allwinner,sun9i-a80-display-backend",
>  	"allwinner,sun50i-a64-csi",
>  	"allwinner,sun50i-a64-video-engine",
>