linux-kernel - Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Sep 2021 04:23:12 +0200
From:   Mike Galbraith <efault@....de>
To:     lkml <linux-kernel@...r.kernel.org>
Cc:     Hyunchul Lee <hyc.lee@...il.com>,
        Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly

typing hard.. Thag forget type [patch]

On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>
> rwlock.h specifically asks to not be included directly.
>
> In fact, the proper spinlock.h include isn't needed either,
> it comes with the huge pile that kthread.h ends up pulling
> in, so just drop it entirely.
>
> Signed-off-by: Mike Galbraith <efault@....de>
> ---
>  fs/ksmbd/transport_rdma.c |    1 -
>  1 file changed, 1 deletion(-)
>
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -20,7 +20,6 @@
>  #define SUBMOD_NAME    "smb_direct"
>
>  #include <linux/kthread.h>
> -#include <linux/rwlock.h>
>  #include <linux/list.h>
>  #include <linux/mempool.h>
>  #include <linux/highmem.h>
>