linux-kernel - Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 12 Sep 2021 12:00:36 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Mike Galbraith <efault@....de>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Hyunchul Lee <hyc.lee@...il.com>,
        CIFS <linux-cifs@...r.kernel.org>
Subject: Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly

2021-09-12 11:23 GMT+09:00, Mike Galbraith <efault@....de>:
> typing hard.. Thag forget type [patch]
I will apply this patch, Thanks for your patch!
>
> On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>>
>> rwlock.h specifically asks to not be included directly.
>>
>> In fact, the proper spinlock.h include isn't needed either,
>> it comes with the huge pile that kthread.h ends up pulling
>> in, so just drop it entirely.
>>
>> Signed-off-by: Mike Galbraith <efault@....de>
>> ---
>>  fs/ksmbd/transport_rdma.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> --- a/fs/ksmbd/transport_rdma.c
>> +++ b/fs/ksmbd/transport_rdma.c
>> @@ -20,7 +20,6 @@
>>  #define SUBMOD_NAME    "smb_direct"
>>
>>  #include <linux/kthread.h>
>> -#include <linux/rwlock.h>
>>  #include <linux/list.h>
>>  #include <linux/mempool.h>
>>  #include <linux/highmem.h>
>>
>
>