linux-kernel - Re: [PATCH v3 1/2] scsi: ufs: Probe for temperature notification support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbe45ecf-853f-77f7-9094-ded8c59075f4@roeck-us.net>
Date:   Mon, 13 Sep 2021 07:24:29 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Avri Altman <Avri.Altman@....com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bart Van Assche <bvanassche@....org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bean Huo <beanhuo@...ron.com>
Subject: Re: [PATCH v3 1/2] scsi: ufs: Probe for temperature notification
 support

On 9/13/21 12:49 AM, Avri Altman wrote:
>>>> The "enable" attribute only makes sense if it can be used to actually
>>>> enable or disable a specific sensor, and is not tied to limit
>>>> attributes but to the actual sensor values.
>>> See explanation above.
>>>    Will make it writable as well.
>>>
>>
>> That only makes sense if the information is passed to the chip. What is going to
>> happen if the user writes 0 into the attribute ?
> Will turn off the temperature exception bits, so that Tcase is no longer valid,
> and the device will always return Tcase = 0.
> 

Ok. Then attempts to read the temperature should return -ENODATA, not -EINVAL,
if Tcase == 0.

Guenter