linux-kernel - Re: [PATCH] media: atomisp: fix control reaches end of non-void function error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f1c09f9-49e1-718b-329c-aae9d2f69266@linuxfoundation.org>
Date:   Mon, 13 Sep 2021 08:24:51 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     mchehab@...nel.org, sakari.ailus@...ux.intel.com,
        gregkh@...uxfoundation.org, paskripkin@...il.com,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] media: atomisp: fix control reaches end of non-void
 function error

On 9/13/21 2:41 AM, Dan Carpenter wrote:
> On Fri, Sep 10, 2021 at 04:37:00PM -0600, Shuah Khan wrote:
>> Fix the following build error with -Werror=return-type enabled. Fix
>> input_system_configure_channel_sensor() to return status when control
>> reaches the end.
>>
>> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o
>> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
>> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
>>   1649 | }
>>
>> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
> 
> Hi Shuah,
> 
> You're the third person to send this patch recently but it was fixed on
> Aug 2 in staging-next in commit 05344a1d2ea7 ("media: atomisp: restore
> missing 'return' statement").  What tree are you working against?  It
> seems like it needs to be backported somewhere.
> 

I am working on Linux 5.15 - should have checked staging next though before
sending the patch :)

thanks,
-- Shuah