[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210913154253.GJ4283@sirena.org.uk>
Date: Mon, 13 Sep 2021 16:42:53 +0100
From: Mark Brown <broonie@...nel.org>
To: Jernej Škrabec <jernej.skrabec@...il.com>
Cc: mripard@...nel.org, wens@...e.org, robh+dt@...nel.org,
lgirdwood@...il.com, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH 1/2] dt-bindings: sound: sun4i-i2s: add Allwinner R40
I2S compatible
On Mon, Sep 13, 2021 at 05:33:22PM +0200, Jernej Škrabec wrote:
> Dne ponedeljek, 13. september 2021 ob 13:11:17 CEST je Mark Brown napisal(a):
> > On Sun, Sep 12, 2021 at 09:29:13AM +0200, Jernej Skrabec wrote:
> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.
> I did exactly that. But history is not uniform:
...
> Most subjects contain "dt-bindings: sound: " at the beginning. I selected
> variant from latest commit (ce09d1a6800d).
If you look at more than just this one file the numbers look rather
different there, I see I will have to start being super strict with the
sunxi stuff here :( . Other people messing up is not a good reason to
follow them, nor is the occasional thing that's part of a larger series
being let slide without a maintainer fixup.
Nothing in this patch series had anything about ASoC in it meaning I
very nearly deleted this unread.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists