linux-kernel - [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 14:05:21 +0200
From:   Florian Eckert <fe@....tdt.de>
To:     peterhuewe@....de, jarkko@...nel.org, jgg@...pe.ca,
        Eckert.Florian@...glemail.com
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor check

On my embedded system I use this tpm infineon chip via i2c bus.
The system is a MIPS architecture and therefore works in big endian mode.

The problem is, that the chip type is not correctly recognized,
because the vendor ID is wrongly aligned in the memory.

By declaring the vendor ID variable as a `__le32` type, the TPM chip is
then correctly recognized by the driver and feels then responsible.

The device works than as expected.

Signed-off-by: Florian Eckert <fe@....tdt.de>
---
v2:
* use variable type instead of le32_to_cpus function call
 drivers/char/tpm/tpm_i2c_infineon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
index a19d32cb4e94..30c320ea57fd 100644
--- a/drivers/char/tpm/tpm_i2c_infineon.c
+++ b/drivers/char/tpm/tpm_i2c_infineon.c
@@ -611,7 +611,7 @@ static const struct tpm_class_ops tpm_tis_i2c = {

 static int tpm_tis_i2c_init(struct device *dev)
 {
-	u32 vendor;
+	__le32 vendor;
 	int rc = 0;
 	struct tpm_chip *chip;

-- 
2.20.1