linux-kernel - Re: [PATCH] reset: pistachio: Re-enable driver selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cea856f-d70e-8564-d12d-79100340a973@flygoat.com>
Date:   Tue, 14 Sep 2021 15:42:52 +0100
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Rahul Bedarkar <rahulbedarkar89@...il.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: pistachio: Re-enable driver selection



在 2021/9/14 10:15, Geert Uytterhoeven 写道:
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
>
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default.  The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
>
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
Reviewed-by: Jiaxun Yang <jiaxun.yang@...goat.com>

Thanks!
> ---
>   drivers/reset/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index be799a5abf8a6edc..b0056ae5d463aedd 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -147,8 +147,8 @@ config RESET_OXNAS
>   	bool
>   
>   config RESET_PISTACHIO
> -	bool "Pistachio Reset Driver" if COMPILE_TEST
> -	default MACH_PISTACHIO
> +	bool "Pistachio Reset Driver"
> +	depends on MIPS || COMPILE_TEST
>   	help
>   	  This enables the reset driver for ImgTec Pistachio SoCs.
>