linux-kernel - Re: [PATCH] reset: pistachio: Re-enable driver selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+NV+Vk-+MrCA4x7kVoVk0Ejr9Qv33PysQjLBzpXqOF4WNfTRw@mail.gmail.com>
Date:   Wed, 15 Sep 2021 10:59:12 +0530
From:   Rahul Bedarkar <rahulbedarkar89@...il.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: pistachio: Re-enable driver selection

On Tue, Sep 14, 2021 at 2:46 PM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
>
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default.  The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
>
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Rahul Bedarkar <rahulbedarkar89@...il.com>

Thanks,
Rahul

> ---
>  drivers/reset/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index be799a5abf8a6edc..b0056ae5d463aedd 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -147,8 +147,8 @@ config RESET_OXNAS
>         bool
>
>  config RESET_PISTACHIO
> -       bool "Pistachio Reset Driver" if COMPILE_TEST
> -       default MACH_PISTACHIO
> +       bool "Pistachio Reset Driver"
> +       depends on MIPS || COMPILE_TEST
>         help
>           This enables the reset driver for ImgTec Pistachio SoCs.
>
> --
> 2.25.1
>