linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d2_som1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3afbdb3-ad68-f277-7405-9e98af1c8f97@microchip.com>
Date:   Tue, 14 Sep 2021 17:03:16 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>
CC:     <robh+dt@...nel.org>, <ludovic.desroches@...rochip.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by
 default

On 02/09/2021 at 14:13, Eugen Hristev wrote:
> Without a sensor node, the ISC will simply fail to probe, as the
> corresponding port node is missing.
> It is then logical to disable the node in the devicetree.
> If we add a port with a connection to a sensor endpoint, ISC can be enabled.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Makes sense:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

And queued for at91-fixes in 5.15 as there is no point continuing to 
have a failing probe on this board.

Thanks, best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> index 614999dcb990..cd4672501add 100644
> --- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> @@ -71,7 +71,6 @@ apb {
>   			isc: isc@...08000 {
>   				pinctrl-names = "default";
>   				pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;
> -				status = "okay";
>   			};
>   
>   			qspi1: spi@...24000 {
> 


-- 
Nicolas Ferre