linux-kernel - Re: [PATCH] rtc: Disable alarm irq if alarm is enabled and alarm time is less than or equal to current time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 14 Sep 2021 23:54:55 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     jianbin zhang <quic_jianbinz@...cinc.com>
Cc:     "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>
Subject: Re: [PATCH] rtc: Disable alarm irq if alarm is enabled and alarm
 time is less than or equal to current time

On 14/09/2021 10:50:33+0800, jianbin zhang wrote:
> 
> On 9/11/21 3:05 AM, Alexandre Belloni wrote:
> > Hello,
> > 
> > Please format your patch properly.
> 
> I am so sorry for bothering you because of the patch format. I test the patch format in the local and
> 
> the format works well. Such case will not occur.
> 
> > > If device is booted up by rtc alarm, the alarm irq  will still be enabled and the alarm time is less than current rtc time before any alarm is set or canceled .
> > > 
> > > If device is shut down this time, it will boot up automatically as the alarm irq is enabled and alarm time is less than current rtc time.
> > > 
> > > 
> > > 
> > > For the situation that the alarm time and rtc time are equal to boot up the device, we expect irq to be false until another alarm is reconfigured, then irq becomes true again.
> > > 
> > > 
> > > 
> > > So disable alarm irq if alarm is enabled and alarm time is less than or equal to current rtc time.
> > > 
> > You should probably fix your driver instead of messing with the core.
> >  From what I understand, you have:
> > 
> >   1/ set the alarm
> >   2/ shutdown
> >   3/ alarm happens, the device boots
> >   4/ shutdown
> >   5/ alarm irq is still set, device boots again
> > 
> > At step 3, your driver has to acknowledge and clear the irq
> 
> Thanks for great reviewing.
> 1/Yeah, the steps you understand are right.
> 2/In fact I met the issue when using the core rtc driver.That means I do not have a private driver on the issue.
> 

Well, the core isn't a driver, which driver are you using?


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com