linux-kernel - Re: [PATCH RESEND v3 13/13] blk-mq: Stop using pointers for blk_mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbbd167f-1b11-6cb4-94fb-7c13aa0b65b5@suse.de>
Date:   Tue, 14 Sep 2021 08:05:28 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, axboe@...nel.dk
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        ming.lei@...hat.com, linux-scsi@...r.kernel.org
Subject: Re: [PATCH RESEND v3 13/13] blk-mq: Stop using pointers for
 blk_mq_tags bitmap tags

On 9/13/21 5:12 PM, John Garry wrote:
> Now that we use shared tags for shared sbitmap support, we don't require
> the tags sbitmap pointers, so drop them.
> 
> This essentially reverts commit 222a5ae03cdd ("blk-mq: Use pointers for
> blk_mq_tags bitmap tags").
> 
> Function blk_mq_init_bitmap_tags() is removed also, since it would be only
> a wrappper for blk_mq_init_bitmaps().
> 
> Reviewed-by: Ming Lei <ming.lei@...hat.com>
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>   block/bfq-iosched.c    |  4 +--
>   block/blk-mq-debugfs.c |  8 +++---
>   block/blk-mq-tag.c     | 56 +++++++++++++++---------------------------
>   block/blk-mq-tag.h     |  7 ++----
>   block/blk-mq.c         |  8 +++---
>   block/kyber-iosched.c  |  4 +--
>   block/mq-deadline.c    |  2 +-
>   7 files changed, 35 insertions(+), 54 deletions(-)
> A round of silent applause :-)

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer