linux-kernel - Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUBIoEYPP7e5+CR0@kroah.com>
Date:   Tue, 14 Sep 2021 09:00:48 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Fei Li <fei1.li@...el.com>
Cc:     linux-kernel@...r.kernel.org, yu1.wang@...el.com,
        shuox.liu@...il.com
Subject: Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual
 device creating/destroying

On Tue, Sep 14, 2021 at 02:26:27PM +0800, Fei Li wrote:
> +struct acrn_vdev {
> +	/*
> +	 * the identifier of the device, the low 32 bits represent the vendor
> +	 * id and device id of PCI device and the high 32 bits represent the
> +	 * device number of the legacy device
> +	 */
> +	union {
> +		__u64 value;
> +		struct {
> +			__u16 vendor;
> +			__u16 device;
> +			__u32 legacy_id;

What is the endian of these fields?

Please always specify them.

thanks,

greg k-h