linux-kernel - Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual device creating/destroying

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210915013554.GA28232@louislifei-OptiPlex-7050>
Date:   Wed, 15 Sep 2021 09:35:54 +0800
From:   Li Fei1 <fei1.li@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, yu1.wang@...el.com,
        shuox.liu@...il.com, fei1.li@...el.com
Subject: Re: [PATCH v4 2/2] virt: acrn: Introduce interfaces for virtual
 device creating/destroying

On Tue, Sep 14, 2021 at 09:00:48AM +0200, Greg KH wrote:
> On Tue, Sep 14, 2021 at 02:26:27PM +0800, Fei Li wrote:
> > +struct acrn_vdev {
> > +	/*
> > +	 * the identifier of the device, the low 32 bits represent the vendor
> > +	 * id and device id of PCI device and the high 32 bits represent the
> > +	 * device number of the legacy device
> > +	 */
> > +	union {
> > +		__u64 value;
> > +		struct {
> > +			__u16 vendor;
> > +			__u16 device;
> > +			__u32 legacy_id;
> 
> What is the endian of these fields?
"Big-endian" or "Little-endian" ? If yes, they're Little-endian.

> 
> Please always specify them.
Sure.
> 
> thanks,
> 
> greg k-h