linux-kernel - [PATCH] hardening: Default to INIT_STACK_ALL_ZERO if CC_HAS_AUTO_VAR_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210914102837.6172-1-will@kernel.org>
Date:   Tue, 14 Sep 2021 11:28:37 +0100
From:   Will Deacon <will@...nel.org>
To:     linux-kernel@...r.kernel.org
Cc:     linux-security-module@...r.kernel.org,
        Will Deacon <will@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [PATCH] hardening: Default to INIT_STACK_ALL_ZERO if CC_HAS_AUTO_VAR_INIT_ZERO

CC_HAS_AUTO_VAR_INIT_ZERO requires a supported set of compiler options
distinct from those needed by CC_HAS_AUTO_VAR_INIT_PATTERN, Fix up
the Kconfig dependency for INIT_STACK_ALL_ZERO to test for the former
instead of the latter, as these are the options passed by the top-level
Makefile.

Cc: Kees Cook <keescook@...omium.org>
Cc: Nathan Chancellor <nathan@...nel.org>
Cc: Nick Desaulniers <ndesaulniers@...gle.com>
Cc: Gustavo A. R. Silva <gustavoars@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Fixes: dcb7c0b9461c ("hardening: Clarify Kconfig text for auto-var-init")
Signed-off-by: Will Deacon <will@...nel.org>
---

I just noticed this while reading the code and I suspect it doesn't really
matter in practice.

 security/Kconfig.hardening | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/Kconfig.hardening b/security/Kconfig.hardening
index 90cbaff86e13..341e2fdcba94 100644
--- a/security/Kconfig.hardening
+++ b/security/Kconfig.hardening
@@ -29,7 +29,7 @@ choice
 	prompt "Initialize kernel stack variables at function entry"
 	default GCC_PLUGIN_STRUCTLEAK_BYREF_ALL if COMPILE_TEST && GCC_PLUGINS
 	default INIT_STACK_ALL_PATTERN if COMPILE_TEST && CC_HAS_AUTO_VAR_INIT_PATTERN
-	default INIT_STACK_ALL_ZERO if CC_HAS_AUTO_VAR_INIT_PATTERN
+	default INIT_STACK_ALL_ZERO if CC_HAS_AUTO_VAR_INIT_ZERO
 	default INIT_STACK_NONE
 	help
 	  This option enables initialization of stack variables at
-- 
2.33.0.309.g3052b89438-goog