linux-kernel - Re: [PATCH v4 15/18] staging: r8188eu: hal: Clean up usbctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Sep 2021 16:05:45 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Michael Straube <straube.linux@...il.com>,
        Pavel Skripkin <paskripkin@...il.com>
Subject: Re: [PATCH v4 15/18] staging: r8188eu: hal: Clean up usbctrl_vendorreq()

On Tuesday, September 14, 2021 3:30:07 PM CEST Dan Carpenter wrote:
> On Tue, Sep 14, 2021 at 03:24:06PM +0200, Fabio M. De Francesco wrote:
> > [...]
> David and I are saying the same thing.  "Reverse Christmas Tree" vs
> "reverse xmas tree".  It's like an upside down pine tree.
> 
> 	asfklajsdfljasldf
> 	asdflkjasldfjal
> 	asdflkjalsdfj
> 	asldfkjalsdf
> 	asldfkjl98
> 	lwkejrlw
> 	ljklkjl
> 	lkjkll
> 	kjld
> 	asdf
> 	x
> 
> regards,
> dan carpenter

Oh, sorry. I interpreted David's message the other way because it seemed to 
me that the code already had this RXT style (with the only exception of the 
"wvalue" variable that now is gone forever). Now I see that I got it wrong 
and that something got lost in translation.

Thank you again,

Fabio