linux-kernel - Re: [PATCH v2 1/3] usb: typec: tipd: Don't read/write more bytes than required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Sep 2021 10:20:09 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Sven Peter <sven@...npeter.dev>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] usb: typec: tipd: Don't read/write more bytes
 than required

On Tue, Sep 14, 2021 at 04:02:33PM +0200, Sven Peter wrote:
> tps6598x_block_read/write always read 65 bytes of data even when much
> less is required when I2C_FUNC_I2C is used. Reduce this to the correct
> number.
> 
> Signed-off-by: Sven Peter <sven@...npeter.dev>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
> no changes for v2
> 
>  drivers/usb/typec/tipd/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 21b3ae25c76d..c18ec3785592 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -123,7 +123,7 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
>  	if (!tps->i2c_protocol)
>  		return regmap_raw_read(tps->regmap, reg, val, len);
>  
> -	ret = regmap_raw_read(tps->regmap, reg, data, sizeof(data));
> +	ret = regmap_raw_read(tps->regmap, reg, data, len + 1);
>  	if (ret)
>  		return ret;
>  
> @@ -145,7 +145,7 @@ static int tps6598x_block_write(struct tps6598x *tps, u8 reg,
>  	data[0] = len;
>  	memcpy(&data[1], val, len);
>  
> -	return regmap_raw_write(tps->regmap, reg, data, sizeof(data));
> +	return regmap_raw_write(tps->regmap, reg, data, len + 1);
>  }
>  
>  static inline int tps6598x_read16(struct tps6598x *tps, u8 reg, u16 *val)
> -- 
> 2.25.1

thanks,

-- 
heikki