linux-kernel - Re: [PATCH mm] mm/vmalloc: repair warn_alloc()s in __vmalloc_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210915135201.GB14571@lst.de>
Date:   Wed, 15 Sep 2021 15:52:01 +0200
From:   Christoph Hellwig <hch@....de>
To:     Vasily Averin <vvs@...tuozzo.com>
Cc:     Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, kernel@...nvz.org
Subject: Re: [PATCH mm] mm/vmalloc: repair warn_alloc()s in
 __vmalloc_area_node()

On Wed, Sep 15, 2021 at 02:43:10PM +0300, Vasily Averin wrote:
> Commit f255935b9767 ("mm: cleanup the gfp_mask handling in
> __vmalloc_area_node") added __GFP_NOWARN to gfp_mask unconditionally
> however it disabled all output inside warn_alloc() call.
> This patch saves original gfp_mask and provides it to all warn_alloc() calls.
> 
> Fixes: f255935b9767 ("mm: cleanup the gfp_mask handling in __vmalloc_area_node")
> Cc: Christoph Hellwig <hch@....de>
> 
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>

Looks fine, thanks.

Reviewed-by: Christoph Hellwig <hch@....de>