linux-kernel - Re: [PATCH mm] mm/vmalloc: repair warn_alloc()s in __vmalloc_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMZfGtXQHRzZ8JZw=jnZ3AB2bdd6yWrGjNf_KpNnL+tQFN5eow@mail.gmail.com>
Date:   Thu, 16 Sep 2021 14:01:07 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Vasily Averin <vvs@...tuozzo.com>
Cc:     Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel@...nvz.org
Subject: Re: [PATCH mm] mm/vmalloc: repair warn_alloc()s in __vmalloc_area_node()

On Wed, Sep 15, 2021 at 7:43 PM Vasily Averin <vvs@...tuozzo.com> wrote:
>
> Commit f255935b9767 ("mm: cleanup the gfp_mask handling in
> __vmalloc_area_node") added __GFP_NOWARN to gfp_mask unconditionally
> however it disabled all output inside warn_alloc() call.
> This patch saves original gfp_mask and provides it to all warn_alloc() calls.
>
> Fixes: f255935b9767 ("mm: cleanup the gfp_mask handling in __vmalloc_area_node")
> Cc: Christoph Hellwig <hch@....de>
>
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>

LGTM. Thanks.

Reviewed-by: Muchun Song <songmuchun@...edance.com>