linux-kernel - RE: [PATCH] AMD_SFH: Fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Sep 2021 17:32:12 +0000
From:   "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>
To:     Jiri Kosina <jikos@...nel.org>, Evgeny Novikov <novikov@...ras.ru>
CC:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>,
        "Natikar, Basavaraj" <Basavaraj.Natikar@....com>
Subject: RE: [PATCH] AMD_SFH: Fix potential NULL pointer dereference

Adding Basavaraj

-----Original Message-----
From: Jiri Kosina <jikos@...nel.org> 
Sent: Wednesday, September 15, 2021 8:28 PM
To: Evgeny Novikov <novikov@...ras.ru>
Cc: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@....com>; Sandeep Singh <sandeep.singh@....com>; Benjamin Tissoires <benjamin.tissoires@...hat.com>; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; ldv-project@...uxtesting.org
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference

On Tue, 1 Jun 2021, Evgeny Novikov wrote:

> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at 
> registration that will cause NULL pointer dereference since 
> corresponding data is not initialized yet. The patch moves 
> initialization of data before devm_add_action_or_reset().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@...ras.ru>

Nehal, Basavaraj, could you please Review/Ack this one?

Thanks,

--
Jiri Kosina
SUSE Labs