linux-kernel - Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Sep 2021 11:29:32 +0530
From:   Basavaraj Natikar <bnatikar@....com>
To:     "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>,
        Jiri Kosina <jikos@...nel.org>,
        Evgeny Novikov <novikov@...ras.ru>
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>,
        "Natikar, Basavaraj" <Basavaraj.Natikar@....com>
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference

On 9/15/2021 11:02 PM, Shah, Nehal-bakulchandra wrote:
> Adding Basavaraj
>
> -----Original Message-----
> From: Jiri Kosina <jikos@...nel.org> 
> Sent: Wednesday, September 15, 2021 8:28 PM
> To: Evgeny Novikov <novikov@...ras.ru>
> Cc: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@....com>; Sandeep Singh <sandeep.singh@....com>; Benjamin Tissoires <benjamin.tissoires@...hat.com>; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; ldv-project@...uxtesting.org
> Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
>
> On Tue, 1 Jun 2021, Evgeny Novikov wrote:
>
>> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at 
>> registration that will cause NULL pointer dereference since 
>> corresponding data is not initialized yet. The patch moves 
>> initialization of data before devm_add_action_or_reset().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Evgeny Novikov <novikov@...ras.ru>
> Nehal, Basavaraj, could you please Review/Ack this one?
>
Patch looks good to me. Acked-by: Basavaraj Natikar <Basavaraj.Natikar@....com>