linux-kernel - Re: [PATCH v2] dt-bindings: mfd: bd9571mwv: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbc3f4bf-78cd-fb97-2502-ab87f9881179@fi.rohmeurope.com>
Date:   Thu, 16 Sep 2021 06:31:45 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Rob Herring <robh+dt@...nel.org>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2] dt-bindings: mfd: bd9571mwv: Convert to json-schema

On 9/15/21 15:14, Geert Uytterhoeven wrote:
> Convert the ROHM BD9571MWV/BD9574MWF Power Management Integrated Circuit
> (PMIC) Device Tree binding documentation to json-schema.
> 
> Make the "regulators" subnode optional, as not all users describe the
> regulators.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---
> I have listed Marek as the maintainer, as he wrote the original
> bindings.  Marek: Please scream if this is inappropriate ;-)
> 
> v2:
>    - Add Reviewed-by.
> ---
>   .../devicetree/bindings/mfd/bd9571mwv.txt     |  69 ----------
>   .../bindings/mfd/rohm,bd9571mwv.yaml          | 127 ++++++++++++++++++
>   2 files changed, 127 insertions(+), 69 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>   create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd9571mwv.yaml
> +                  regulators {
> +                          dvfs: dvfs {
> +                                  regulator-name = "dvfs";
> +                                  regulator-min-microvolt = <750000>;
> +                                  regulator-max-microvolt = <1030000>;
> +                                  regulator-boot-on;
> +                                  regulator-always-on;
Out of the curiosity (and in order to learn) - what is the exact idea of 
the 'regulator-boot-on' and when it should be used? I _think_ the 
'regulator-boot-on' is in many cases used to make the regulator 
framework to enable the regulator at start-up. What I _think_ the 
'regulator-boot-on' is intended for is to advertise the regulator 
boot-up state for regulators which do not provide a way to get the 
state. I am unsure if there is any property which is intended to be used 
for enabling the regulator at start-up. DISCLAIMER: Source of these 
thoughts is unknown. I may be wrong here. If someone knows this for sure 
I'd be grateful for any education :) If I am not mistaken the dvfs 
regulator does provide a way of reading the enable state after boot.

Finally, I have seen this quite many times before but I am unsure I 
understand it - why setting both the 'regulator-boot-on' and 
'regulator-always-on'? Wouldn't the 'regulator-always-on' suffice?
> +                          };
> +                  };
> +          };
> +    };
> 

Anyways - as I mentioned, I am not 100% sure of pretty much anything :) 
Hence my questions are just questions - and the binding looks good to me.

FWIW:
acked-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

--Matti