linux-kernel - Re: [PATCH v2] dt-bindings: mfd: bd9571mwv: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Sep 2021 08:35:20 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2] dt-bindings: mfd: bd9571mwv: Convert to json-schema

Hi Matti,

On Thu, Sep 16, 2021 at 8:31 AM Vaittinen, Matti
<Matti.Vaittinen@...rohmeurope.com> wrote:
> On 9/15/21 15:14, Geert Uytterhoeven wrote:
> > Convert the ROHM BD9571MWV/BD9574MWF Power Management Integrated Circuit
> > (PMIC) Device Tree binding documentation to json-schema.
> >
> > Make the "regulators" subnode optional, as not all users describe the
> > regulators.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > ---
> > I have listed Marek as the maintainer, as he wrote the original
> > bindings.  Marek: Please scream if this is inappropriate ;-)
> >
> > v2:
> >    - Add Reviewed-by.
> > ---
> >   .../devicetree/bindings/mfd/bd9571mwv.txt     |  69 ----------
> >   .../bindings/mfd/rohm,bd9571mwv.yaml          | 127 ++++++++++++++++++
> >   2 files changed, 127 insertions(+), 69 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> >   create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd9571mwv.yaml
> > +                  regulators {
> > +                          dvfs: dvfs {
> > +                                  regulator-name = "dvfs";
> > +                                  regulator-min-microvolt = <750000>;
> > +                                  regulator-max-microvolt = <1030000>;
> > +                                  regulator-boot-on;
> > +                                  regulator-always-on;
> Out of the curiosity (and in order to learn) - what is the exact idea of
> the 'regulator-boot-on' and when it should be used? I _think_ the
> 'regulator-boot-on' is in many cases used to make the regulator
> framework to enable the regulator at start-up. What I _think_ the
> 'regulator-boot-on' is intended for is to advertise the regulator
> boot-up state for regulators which do not provide a way to get the
> state. I am unsure if there is any property which is intended to be used
> for enabling the regulator at start-up. DISCLAIMER: Source of these
> thoughts is unknown. I may be wrong here. If someone knows this for sure
> I'd be grateful for any education :) If I am not mistaken the dvfs
> regulator does provide a way of reading the enable state after boot.
>
> Finally, I have seen this quite many times before but I am unsure I
> understand it - why setting both the 'regulator-boot-on' and
> 'regulator-always-on'? Wouldn't the 'regulator-always-on' suffice?
> > +                          };
> > +                  };
> > +          };
> > +    };
> >
>
> Anyways - as I mentioned, I am not 100% sure of pretty much anything :)
> Hence my questions are just questions - and the binding looks good to me.

I have to defer to the regulator experts to answer those questions...

> FWIW:
> acked-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

s/a/A/

Thank you!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds