linux-kernel - Re: [PATCH v2 0/2] riscv: improve unaligned memory accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9200c4c2-44b9-480e-6970-5188640fb00a@huawei.com>
Date:   Sat, 18 Sep 2021 09:14:05 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Jisheng Zhang <jszhang3@...l.ustc.edu.cn>,
        Chen Huang <chenhuang5@...wei.com>
CC:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Darius Rad <darius@...espec.com>,
        <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] riscv: improve unaligned memory accesses


On 2021/9/17 22:14, Jisheng Zhang wrote:
> On Thu, 16 Sep 2021 13:08:53 +0000
> Chen Huang <chenhuang5@...wei.com> wrote:
>
>> The patchset improves RISCV unaligned memory accesses, selects
>> HAVE_EFFICIENT_UNALIGNED_ACCESS if CPU_HAS_NO_UNALIGNED not
>> enabled and supports DCACHE_WORD_ACCESS to improve the efficiency
>> of unaligned memory accesses.
>>
>> If CPU don't support unaligned memory accesses for now, please
>> select CONFIG_CPU_HAS_NO_UNALIGNED. For I don't know which CPU
>> don't support unaligned memory accesses, I don't choose the
>> CONFIG for them.
> This will break unified kernel Image for riscv. Obviously, we will have
> two images for efficient unaligned access platforms and non-efficient
> unaligned access platforms. IMHO, we may need alternative mechanism or
> something else to dynamically enable related code path.

it won't break unified kernel Image for riscv, if one SoC choose

CPU_HAS_NO_UNALIGNED, the single Image won't support unaligned memory

accesses, indeed, it depends on the CONFIG, and now, arm/powerpc/m68k has

similar configuration.

Yes,  it could be an optimization via alternative mechanism or something 
else to

dynamically enable related code path later.

>
> Regards
>
>> Changes since v1:
>>   - As Darius Rad and Jisheng Zhang mentioned, some CPUs don't support
>>     unaligned memory accesses, add an option for CPUs to choose it or not.
>>
>> Chen Huang (2):
>>    riscv: support HAVE_EFFICIENT_UNALIGNED_ACCESS
>>    riscv: Support DCACHE_WORD_ACCESS
>>
>>   arch/riscv/Kconfig                      |  5 ++++
>>   arch/riscv/include/asm/word-at-a-time.h | 37 +++++++++++++++++++++++++
>>   2 files changed, 42 insertions(+)
>>
>
> .
>