linux-kernel - Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89d9424a-d792-633a-d8e8-cebe7c3a2e20@lwfinger.net>
Date:   Sat, 18 Sep 2021 11:46:50 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Michael Straube <straube.linux@...il.com>,
        Phillip Potter <phil@...lpotter.co.uk>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

On 9/18/21 08:31, Michael Straube wrote:
> Hi Larry, Phillip and all.
> 
> While removing code that checks for the chip type I stumbled upon this:
> 
> 
> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
> {
>      if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
>          return;
> 
>      if (pDM_Odm->SupportICType == ODM_RTL8188E) {
>          /*  ??? */
>          /*  This part need to be redefined. */
>      }
> }
> 
> 
> (pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver.
> Currently the function does nothing and the driver seems to work fine.
> Because of the comment I'm not sure if the whole function can just be
> removed?

Yes, I agree. No later driver does anything with this routine, thus it is dead 
and can be removed.

Larry