linux-kernel - Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0701af92-b341-f7b0-8a0c-3bea8a69f580@gmail.com>
Date:   Sat, 18 Sep 2021 19:32:31 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

On 9/18/21 18:46, Larry Finger wrote:
> On 9/18/21 08:31, Michael Straube wrote:
>> Hi Larry, Phillip and all.
>>
>> While removing code that checks for the chip type I stumbled upon this:
>>
>>
>> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
>> {
>>      if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
>>          return;
>>
>>      if (pDM_Odm->SupportICType == ODM_RTL8188E) {
>>          /*  ??? */
>>          /*  This part need to be redefined. */
>>      }
>> }
>>
>>
>> (pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver.
>> Currently the function does nothing and the driver seems to work fine.
>> Because of the comment I'm not sure if the whole function can just be
>> removed?
> 
> Yes, I agree. No later driver does anything with this routine, thus it 
> is dead and can be removed.
> 
> Larry
> 

Ok, thank you.

Regards,
Michael