linux-kernel - Re: [PATCH] iio: adc: rockchip_saradc: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210919183447.33adf804@jic23-huawei>
Date:   Sun, 19 Sep 2021 18:34:47 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Heiko Stuebner <heiko@...ech.de>, <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: rockchip_saradc: Make use of the helper
 function devm_platform_ioremap_resource()

On Wed, 8 Sep 2021 18:56:30 +0800
Cai Huoqing <caihuoqing@...du.com> wrote:

> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Hi Cai,

Applied to the togreg branch of iio.git and pushed out as testing for 0-day to
see if it can find anything we missed.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/rockchip_saradc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index a237fe469a30..a56a0d7337ca 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -319,7 +319,6 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
>  	struct rockchip_saradc *info = NULL;
>  	struct device_node *np = pdev->dev.of_node;
>  	struct iio_dev *indio_dev = NULL;
> -	struct resource	*mem;
>  	const struct of_device_id *match;
>  	int ret;
>  	int irq;
> @@ -348,8 +347,7 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
>  
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	info->regs = devm_ioremap_resource(&pdev->dev, mem);
> +	info->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(info->regs))
>  		return PTR_ERR(info->regs);
>