linux-kernel - Re: [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com>
Date:   Sun, 19 Sep 2021 23:02:14 +0530
From:   Alim Akhtar <alim.akhtar@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Pankaj Dubey <pankaj.dubey@...sung.com>
Subject: Re: [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module!

Hello Krzysztof

On Sun, Sep 19, 2021 at 6:28 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> Hi,
>
> Changes since v1
> ================
> 1. Drop patch 1/2 - exporting soc_device_to_device
> 2. Add new patches: 1/3 and 3/3.
>
> Question
> ========
>
> A question - what is the convention for naming modules: underscores '_' or
> hyphens '-'?
>
> The C-unit file already uses a hyphen "exynos-chipid.c", so I could
> create a module named:
> 1. exynos_chipid
> 2. soc-exynos-chipid
> 3. exynos-chip-id
>
> The Linux device name is "exynos-chipid".
>
> Best regards,
> Krzysztof
>
>
> Krzysztof Kozlowski (3):
>   soc: samsung: exynos-chipid: avoid soc_device_to_device()
>   soc: samsung: exynos-chipid: convert to a module
>   soc: samsung: exynos-chipid: do not enforce built-in
>
>  arch/arm/mach-exynos/Kconfig         |  1 -
>  drivers/soc/samsung/Kconfig          |  4 +++-
>  drivers/soc/samsung/Makefile         |  3 ++-
>  drivers/soc/samsung/exynos-chipid.c  | 14 +++++++++++---
>  drivers/soc/samsung/exynos5422-asv.c |  1 +
>  5 files changed, 17 insertions(+), 6 deletions(-)
>
Thanks for the patches. For this series
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

Also tested on exynos7 based platform, so
Tested-by: Alim Akhtar <alim.akhtar@...sung.com>

> --
> 2.30.2
>


-- 
Regards,
Alim