linux-kernel - Re: [PATCH 0/5] lib: devres: Add managed helpers for write-combine setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70962c8d-ba1a-8c68-b509-393b6a2ecdca@suse.de>
Date:   Mon, 20 Sep 2021 10:01:40 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Hans de Goede <hdegoede@...hat.com>, airlied@...hat.com,
        airlied@...ux.ie, daniel@...ll.ch, marcan@...can.st,
        maz@...nel.org, akpm@...ux-foundation.org, npiggin@...il.com,
        thunder.leizhen@...wei.com, gregkh@...uxfoundation.org
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] lib: devres: Add managed helpers for write-combine
 setup

Hi

Am 17.09.21 um 16:47 schrieb Hans de Goede:
> Hi,
> 
> On 9/16/21 8:15 PM, Thomas Zimmermann wrote:
>> Add devm_arch_phys_wc_add() and devm_arch_io_reserve_memtype_wc() for
>> automatic cleanup of writecombine setup.
>>
>> Several DRM drivers use the non-managed functions for setting their
>> framebuffer memory to write-combine access. Convert ast, mgag200 and
>> vboxvideo. Remove rsp clean-up code form drivers.
>>
>> Tested on mgag200 hardware.
>>
>> Thomas Zimmermann (5):
>>    lib: devres: Add managed arch_phys_wc_add()
>>    lib: devres: Add managed arch_io_reserve_memtype_wc()
>>    drm/ast: Use managed interfaces for framebuffer write combining
>>    drm/mgag200: Use managed interfaces for framebuffer write combining
>>    drm/vboxvideo: Use managed interfaces for framebuffer write combining
> 
> Thanks, the entire series looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> 
> For the series.

Thanks. Let me know if I can review some DRM code for you, as Daniel 
suggested.

I'll wait a bit before merging the patches. Maybe devres devs want to 
comment.

Best regards
Thomas

> 
> Regards,
> 
> Hans
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)