linux-kernel - Re: [PATCH] hwmon: dell-smm-hwmon: remove unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a10NR5CqoTxtjyrx5g6kO-hEkhaw7psEJHSSOZM9S+JXQ@mail.gmail.com>
Date:   Mon, 20 Sep 2021 15:14:40 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Pali Rohár <pali@...nel.org>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Armin Wolf <W_Armin@....de>, Arnd Bergmann <arnd@...db.de>,
        Carlos Alberto Lopez Perez <clopez@...lia.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Sebastian Oechsle <setboolean@...oud.com>,
        linux-hwmon@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwmon: dell-smm-hwmon: remove unused variable warning

On Mon, Sep 20, 2021 at 2:31 PM Pali Rohár <pali@...nel.org> wrote:
> On Monday 20 September 2021 14:14:16 Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > When procfs is disabled
>
> ... then the i8k_init_procfs function should not be called as the
> purpose of I8K code / config option is to export functionality over
> procfs. So when procfs is disabled then this i8k is noop.
>
> Patch which do not allow compilation of I8K when procfs is not enabled
> is pending here:
>
> https://lore.kernel.org/linux-hwmon/20210910071921.16777-1-rdunlap@infradead.org/
>
> Ideally please test or review it. As you are not the first one who
> spotted -Werror problems with i8k and tried to workaround it.

Ok, I'm now using that version in my randconfig tree, it looks sensible
and it addresses another problem. I'll let you know if something else
comes up with that patch applied, but I'm sure it fixes the issue
I reported. Feel free to add

Reported-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Arnd Bergmann <arnd@...db.de>

to Randy's patch if you like.

> > the code produces a warning
> > for an unused variable:
> >
> > drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_init_procfs':
> > drivers/hwmon/dell-smm-hwmon.c:624:31: error: unused variable 'data' [-Werror=unused-variable]
> >   624 |         struct dell_smm_data *data = dev_get_drvdata(dev);
> >       |                               ^~~~
>
> I'm starting to hate this -Werror decision... but seems that we have to
> deal with it and together cleanup code as much as possible.

Oh, I totally would have sent you my patch without the -Werror change
as well ;-)

       Arnd