linux-kernel - Re: [PATCH] hwmon: dell-smm-hwmon: remove unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 07:19:19 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Pali Rohár <pali@...nel.org>,
        Jean Delvare <jdelvare@...e.com>, Armin Wolf <W_Armin@....de>,
        Arnd Bergmann <arnd@...db.de>,
        Carlos Alberto Lopez Perez <clopez@...lia.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Sebastian Oechsle <setboolean@...oud.com>,
        linux-hwmon@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwmon: dell-smm-hwmon: remove unused variable warning

On Mon, Sep 20, 2021 at 03:14:40PM +0200, Arnd Bergmann wrote:
> On Mon, Sep 20, 2021 at 2:31 PM Pali Rohár <pali@...nel.org> wrote:
> > On Monday 20 September 2021 14:14:16 Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@...db.de>
> > >
> > > When procfs is disabled
> >
> > ... then the i8k_init_procfs function should not be called as the
> > purpose of I8K code / config option is to export functionality over
> > procfs. So when procfs is disabled then this i8k is noop.
> >
> > Patch which do not allow compilation of I8K when procfs is not enabled
> > is pending here:
> >
> > https://lore.kernel.org/linux-hwmon/20210910071921.16777-1-rdunlap@infradead.org/
> >
> > Ideally please test or review it. As you are not the first one who
> > spotted -Werror problems with i8k and tried to workaround it.
> 
> Ok, I'm now using that version in my randconfig tree, it looks sensible
> and it addresses another problem. I'll let you know if something else
> comes up with that patch applied, but I'm sure it fixes the issue
> I reported. Feel free to add
> 
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> 
> to Randy's patch if you like.
> 
You'd have to reply to the patch. This is in x86 world and I can not apply
it, or at least not without Ack from an x86 maintainer. They went ballistic
on me once for doing that, and I won't do it again.

Guenter