linux-kernel - Re: [PATCH v3 7/9] dt-bindings: arm: fsl: clean-up all toradex boards/modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0568e8c5c46ebc04530b09c14c500d9ae8d5e51.camel@toradex.com>
Date:   Mon, 20 Sep 2021 14:19:29 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "leoyang.li@....com" <leoyang.li@....com>,
        "linux@...pel-privat.de" <linux@...pel-privat.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "s.riedmueller@...tec.de" <s.riedmueller@...tec.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "tharvey@...eworks.com" <tharvey@...eworks.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "frowand.list@...il.com" <frowand.list@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH v3 7/9] dt-bindings: arm: fsl: clean-up all toradex
 boards/modules

Hi Rob

On Mon, 2021-09-20 at 07:28 -0500, Rob Herring wrote:
> On Sun, 19 Sep 2021 14:55:34 +0200, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > 
> > Simplify and unify the distinction between modules and carrier boards.
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > Acked-by: Rob Herring <robh@...nel.org>
> > Reviewed-by: Fabio Estevam <festevam@...il.com>
> > 
> > ---
> > 
> > Changes in v3:
> > - Add Fabio's reviewed-by. Thanks!
> > - Add Rob's ack. Thanks!
> > 
> > Changes in v2:
> > - New patch cleaning-up dt-bindings documentation.
> > 
> >  .../devicetree/bindings/arm/fsl.yaml          | 79 ++++++++++---------
> >  1 file changed, 41 insertions(+), 38 deletions(-)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters)
> (line-length)
> ./Documentation/devicetree/bindings/arm/fsl.yaml:612:111: [warning] line too long (113 > 110 characters)
> (line-length)
> 
> dtschema/dtc warnings/errors:
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/1529833
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade

Strange, I have done all of that but I still can not convince dt_binding_check on my system to show me that
same yamllint warnings/errors on that fsl.yaml file. However, it otherwise seems to work as it shows dozens of
other issues throughout Documentation/devicetree/bindings but those are not for me to fix, at least not right
now (;-p).

> Please check and re-submit.

Anyway, I already prepared a V4 with this fixed. Just about to send it out.

Thanks, and sorry again that I missed this.

Cheers

Marcel