linux-kernel - Re: [PATCH 1/1] mm/migrate: de-duplicate migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90e7cefd-5ca0-f284-8c96-743e0f5ef8f4@gmail.com>
Date:   Wed, 22 Sep 2021 13:53:40 +0800
From:   Weizhao Ouyang <o451686892@...il.com>
To:     John Hubbard <jhubbard@...dia.com>
Cc:     akpm@...ux-foundation.org, almasrymina@...gle.com,
        dave.hansen@...ux.intel.com, khandual@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org, mhocko@...e.com,
        minchan@...nel.org, osalvador@...e.de, pasha.tatashin@...een.com,
        weixugc@...gle.com, willy@...radead.org,
        yang.shi@...ux.alibaba.com, ying.huang@...el.com, ziy@...dia.com
Subject: Re: [PATCH 1/1] mm/migrate: de-duplicate migrate_reason strings


On 2021/9/22 12:17, John Hubbard wrote:
> In order to remove the need to manually keep three different files in
> synch, provide a common definition of the mapping between enum
> migrate_reason, and the associated strings for each enum item.
>
> 1. Use the tracing system's mapping of enums to strings, by redefining
> and reusing the MIGRATE_REASON and supporting macros, and using that to
> populate the string array in mm/debug.c.
>
> 2. Move enum migrate_reason to migrate_mode.h. This is not strictly
> necessary for this patch, but migrate mode and migrate reason go
> together, so this will slightly clarify things.
>
> Cc: Weizhao Ouyang <o451686892@...il.com>
> Cc: "Huang, Ying" <ying.huang@...el.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
>  include/linux/migrate.h      | 19 +------------------
>  include/linux/migrate_mode.h | 13 +++++++++++++
>  mm/debug.c                   | 20 +++++++++++---------
>  3 files changed, 25 insertions(+), 27 deletions(-)

LGTM.
And, maybe rename the migrate_mode.h?

Reviewed-by: Weizhao Ouyang <o451686892@...il.com>

Thanks,
Weizhao