linux-kernel - Re: [PATCH 1/1] mm/migrate: de-duplicate migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad62ee8c-c5c1-e02c-9225-3883f03aa0e1@nvidia.com>
Date:   Tue, 21 Sep 2021 23:00:04 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Weizhao Ouyang <o451686892@...il.com>
Cc:     akpm@...ux-foundation.org, almasrymina@...gle.com,
        dave.hansen@...ux.intel.com, khandual@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org, mhocko@...e.com,
        minchan@...nel.org, osalvador@...e.de, pasha.tatashin@...een.com,
        weixugc@...gle.com, willy@...radead.org,
        yang.shi@...ux.alibaba.com, ying.huang@...el.com, ziy@...dia.com
Subject: Re: [PATCH 1/1] mm/migrate: de-duplicate migrate_reason strings

On 9/21/21 22:53, Weizhao Ouyang wrote:
> 
> On 2021/9/22 12:17, John Hubbard wrote:
>> In order to remove the need to manually keep three different files in
>> synch, provide a common definition of the mapping between enum
>> migrate_reason, and the associated strings for each enum item.
>>
>> 1. Use the tracing system's mapping of enums to strings, by redefining
>> and reusing the MIGRATE_REASON and supporting macros, and using that to
>> populate the string array in mm/debug.c.
>>
>> 2. Move enum migrate_reason to migrate_mode.h. This is not strictly
>> necessary for this patch, but migrate mode and migrate reason go
>> together, so this will slightly clarify things.
>>
>> Cc: Weizhao Ouyang <o451686892@...il.com>
>> Cc: "Huang, Ying" <ying.huang@...el.com>
>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
>> ---
>>   include/linux/migrate.h      | 19 +------------------
>>   include/linux/migrate_mode.h | 13 +++++++++++++
>>   mm/debug.c                   | 20 +++++++++++---------
>>   3 files changed, 25 insertions(+), 27 deletions(-)
> 
> LGTM.
> And, maybe rename the migrate_mode.h?
> 

I thought about this, and after failing to dream up a better
filename, just figured I'd leave it alone. But I'm open to suggestion
there. And it is easy to change, since it's only included from two
places.

> Reviewed-by: Weizhao Ouyang <o451686892@...il.com>

Thanks for the review!


thanks,
-- 
John Hubbard
NVIDIA