linux-kernel - Re: [PATCH v6 1/2] drm/bridge: parade-ps8640: Use regmap APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XNSb-ZNoHzjUQJ2JntF3D4nAoKQ_OLo_7jLomnvdFJ6Q@mail.gmail.com>
Date:   Thu, 23 Sep 2021 14:02:21 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Philip Chen <philipchen@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jonas Karlman <jonas@...boo.se>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v6 1/2] drm/bridge: parade-ps8640: Use regmap APIs

Hi,

On Tue, Sep 21, 2021 at 11:06 AM Philip Chen <philipchen@...omium.org> wrote:
>
> Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
> which will simplify the future update on ps8640 driver.
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Acked-by: Sam Ravnborg <sam@...nborg.org>
> Signed-off-by: Philip Chen <philipchen@...omium.org>
> ---
>
> (no changes since v4)
>
> Changes in v4:
> - Remove excessive error logging from the probe function
>
> Changes in v3:
> - Fix the nits from v2 review
>
> Changes in v2:
> - Add separate reg map config per page
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 94 ++++++++++++++++++--------
>  1 file changed, 64 insertions(+), 30 deletions(-)

Pushed both patches to drm-misc-next:

13afcdd7277e drm/bridge: parade-ps8640: Add support for AUX channel
692d8db0a5ca drm/bridge: parade-ps8640: Use regmap APIs

I made a few whitespace fixes reported by `dim apply-branch` (DRM
committer tool) and also re-arranged your Signed-off-by to be above
the Reviews/Acks.

-Doug