lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 03:30:58 +0300 From: Laurent Pinchart <laurent.pinchart@...asonboard.com> To: Rob Clark <robdclark@...il.com> Cc: dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org, Douglas Anderson <dianders@...omium.org>, Rob Clark <robdclark@...omium.org>, Andrzej Hajda <a.hajda@...sung.com>, Neil Armstrong <narmstrong@...libre.com>, Robert Foss <robert.foss@...aro.org>, Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 2/3] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid() Hi Rob, Thank you for the patch. On Mon, Sep 20, 2021 at 03:57:59PM -0700, Rob Clark wrote: > From: Rob Clark <robdclark@...omium.org> > > For the brave new world of bridges not creating their own connectors, we > need to implement the max clock limitation via bridge->mode_valid() > instead of connector->mode_valid(). > > v2: Drop unneeded connector->mode_valid() > > Signed-off-by: Rob Clark <robdclark@...omium.org> > Reviewed-by: Douglas Anderson <dianders@...omium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 41d48a393e7f..6154bed0af5b 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -615,20 +615,8 @@ static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector) > return drm_bridge_get_modes(pdata->next_bridge, connector); > } > > -static enum drm_mode_status > -ti_sn_bridge_connector_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* maximum supported resolution is 4K at 60 fps */ > - if (mode->clock > 594000) > - return MODE_CLOCK_HIGH; > - > - return MODE_OK; > -} > - > static struct drm_connector_helper_funcs ti_sn_bridge_connector_helper_funcs = { > .get_modes = ti_sn_bridge_connector_get_modes, > - .mode_valid = ti_sn_bridge_connector_mode_valid, > }; > > static const struct drm_connector_funcs ti_sn_bridge_connector_funcs = { > @@ -766,6 +754,18 @@ static void ti_sn_bridge_detach(struct drm_bridge *bridge) > drm_dp_aux_unregister(&bridge_to_ti_sn65dsi86(bridge)->aux); > } > > +static enum drm_mode_status > +ti_sn_bridge_mode_valid(struct drm_bridge *bridge, > + const struct drm_display_info *info, > + const struct drm_display_mode *mode) > +{ > + /* maximum supported resolution is 4K at 60 fps */ > + if (mode->clock > 594000) > + return MODE_CLOCK_HIGH; > + > + return MODE_OK; > +} > + > static void ti_sn_bridge_disable(struct drm_bridge *bridge) > { > struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); > @@ -1127,6 +1127,7 @@ static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > static const struct drm_bridge_funcs ti_sn_bridge_funcs = { > .attach = ti_sn_bridge_attach, > .detach = ti_sn_bridge_detach, > + .mode_valid = ti_sn_bridge_mode_valid, > .pre_enable = ti_sn_bridge_pre_enable, > .enable = ti_sn_bridge_enable, > .disable = ti_sn_bridge_disable, -- Regards, Laurent Pinchart
Powered by blists - more mailing lists