lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 08:54:58 +0800 From: Dongliang Mu <mudongliangabcd@...il.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Corentin Labbe <clabbe.montjoie@...il.com>, "David S. Miller" <davem@...emloft.net>, Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Eric Biggers <ebiggers@...gle.com>, Xiang Chen <chenxiang66@...ilicon.com>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Corentin Labbe <clabbe@...libre.com>, "Jason A. Donenfeld" <Jason@...c4.com>, Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] crypto: sun8i-ce: fix multiple memory leaks in sun8i_ce_hash_run On Mon, Aug 16, 2021 at 9:21 PM Dongliang Mu <mudongliangabcd@...il.com> wrote: > > On Thu, Aug 12, 2021 at 6:43 PM Herbert Xu <herbert@...dor.apana.org.au> wrote: > > > > On Thu, Aug 12, 2021 at 06:40:20PM +0800, Dongliang Mu wrote: > > > > > > I agree with you and would like to modify "return 0" to "return err" > > > in the next version. Even if the parent function does not care about > > > the return value, it is still necessary to keep the right return > > > value. > > > > Well if the parent is ignoring the error then returning the error > > there obviously isn't going to help. > > If so, do I still need to change my current patch? Any update on this thread? > > Dongliang Mu > > > > > Cheers, > > -- > > Email: Herbert Xu <herbert@...dor.apana.org.au> > > Home Page: http://gondor.apana.org.au/~herbert/ > > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists