lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 07:58:36 -0500 From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> To: Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>, Daniel Baluta <daniel.baluta@....nxp.com>, broonie@...nel.org Cc: alsa-devel@...a-project.org, kai.vehmanen@...ux.intel.com, lgirdwood@...il.com, linux-kernel@...r.kernel.org, ranjani.sridharan@...ux.intel.com, Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>, daniel.baluta@....com Subject: Re: [PATCH v2 10/12] ASoC: SOF: Intel: hda: make sure DAI widget is set up before IPC >> +static struct sof_ipc_dai_config *hda_dai_update_config(struct snd_soc_dapm_widget *w, >> + int channel) >> { >> + struct snd_sof_widget *swidget = w->dobj.private; >> struct sof_ipc_dai_config *config; >> struct snd_sof_dai *sof_dai; >> - struct sof_ipc_reply reply; >> - int ret = 0; >> >> - list_for_each_entry(sof_dai, &hda_stream->sdev->dai_list, list) { >> - if (!sof_dai->cpu_dai_name) >> - continue; >> + if (!swidget) { >> + dev_err(swidget->scomp->dev, "error: No private data for widget %s\n", w->name); > > NULL pointer dereference, just return NULL without the print. The caller > is printing anyways. yes good catch, we need a v3 with the fixes suggested by Peter in https://github.com/thesofproject/linux/pull/3171/ applied.
Powered by blists - more mailing lists