lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 10:24:34 -0600 From: Mathieu Poirier <mathieu.poirier@...aro.org> To: German Gomez <german.gomez@....com> Cc: linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org, Andrew Kilroy <andrew.kilroy@....com>, John Garry <john.garry@...wei.com>, Will Deacon <will@...nel.org>, Leo Yan <leo.yan@...aro.org>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>, Mike Leach <mike.leach@...aro.org>, linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format Hi German, On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > From: Andrew Kilroy <andrew.kilroy@....com> > > Since the size is already printed earlier in hex, print the same data > using the same format, in hex. > > Reviewed-by: James Clark <james.clark@....com> > Signed-off-by: Andrew Kilroy <andrew.kilroy@....com> > Signed-off-by: German Gomez <german.gomez@....com> > --- > tools/perf/util/cs-etm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index f323adb1af85..4f672f7d008c 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq, > > fprintf(stdout, "\n"); > color_fprintf(stdout, color, > - ". ... CoreSight %s Trace data: size %zu bytes\n", > + ". ... CoreSight %s Trace data: size %#zx bytes\n", Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org> A couple of things to improve for your next interactions with the Linux community: 1) Using a cover letter, even for small changes, is always a good idea. 2) RB tags should be picked up publicly rather than done internally and added to a patchset. 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do with 01, 02 and 03. Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to this patchset. As such he will not see your work. Ask James about how to proceed when submitting patches to the perf tools. Thanks, Mathieu > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > do { > -- > 2.17.1 >
Powered by blists - more mailing lists