linux-kernel - Re: [PATCH 1/5] perf cs-etm: Print size using consistent format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Sep 2021 13:09:16 +0100
From:   German Gomez <german.gomez@....com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Andrew Kilroy <andrew.kilroy@....com>,
        John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>, Leo Yan <leo.yan@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Mike Leach <mike.leach@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org
Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format

Hi Mathieu,

Thanks for your feedback. I will keep these points in mind for future 
submissions.

On 23/09/2021 17:24, Mathieu Poirier wrote:
> Hi German,
>
> On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote:
>> [...]
> Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org>
>
> A couple of things to improve for your next interactions with the Linux community:
>
> 1) Using a cover letter, even for small changes, is always a good idea.
> 2) RB tags should be picked up publicly rather than done internally and added to
> a patchset.
> 3) Keep patches semantically grouped.  Here patches 04 and 05 have nothing to do
> with 01, 02 and 03.
Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 
05 because
they were related to snapshot mode.

Thanks,
German

>
> Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to
> this patchset.  As such he will not see your work.  Ask James about how to
> proceed when submitting patches to the perf tools.
>
> Thanks,
> Mathieu
>
>>   		     cs_etm_decoder__get_name(etmq->decoder), buffer->size);
>>   
>>   	do {
>> -- 
>> 2.17.1
>>