linux-kernel - Re: [PATCH] x86/resctrl: Fix return code in mkdir_rdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <600c2857-8a5f-df1e-0edc-65fea2aae078@intel.com>
Date:   Fri, 24 Sep 2021 11:53:29 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Shaopeng Tan <tan.shaopeng@...fujitsu.com>,
        Fenghua Yu <fenghua.yu@...el.com>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        <x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/resctrl: Fix return code in mkdir_rdt_prepare()

Hi Shaopeng Tan,

On 9/24/2021 1:17 AM, Shaopeng Tan wrote:
> When kzalloc fails, we should return ENOMEM instead of ENOSPC.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
> ---
> Hello,
> 
> I just noticed this when I read the code.
> 
> Thanks,
> 
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index b57b3db9a6a7..a92d047476f6 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -2854,7 +2854,7 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
>   	/* allocate the rdtgroup. */
>   	rdtgrp = kzalloc(sizeof(*rdtgrp), GFP_KERNEL);
>   	if (!rdtgrp) {
> -		ret = -ENOSPC;
> +		ret = -ENOMEM;
>   		rdt_last_cmd_puts("Kernel out of memory\n");
>   		goto out_unlock;
>   	}
> 

I do not know the original motivation for using ENOSPC but from what I 
can tell this error is propagated all the way to user space. This change 
thus has the consequence that any interface built on top of resctrl 
could be impacted.

Is there a specific issue that you are aiming to fix here?

Reinette