linux-kernel - Re: [PATCH] platform/chrome: cros-ec-typec: Cleanup use of check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTemBe5EePGkTTzB_fOKjr=1W_oCuMDVg11jK-0+ZtujMg@mail.gmail.com>
Date:   Thu, 23 Sep 2021 17:25:19 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] platform/chrome: cros-ec-typec: Cleanup use of check_features

On Thu, Sep 23, 2021 at 1:03 PM Prashant Malani <pmalani@...omium.org> wrote:
>
> cros_ec_check_features() now returns a boolean. Remove the double NOT
> operator since it's not required anymore.
>
> No functional changes are expected with this patch.
>
> Signed-off-by: Prashant Malani <pmalani@...omium.org>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>  drivers/platform/chrome/cros_ec_typec.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 262a891eded3..7b3afb6cda5d 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -1116,9 +1116,8 @@ static int cros_typec_probe(struct platform_device *pdev)
>         }
>
>         ec_dev = dev_get_drvdata(&typec->ec->ec->dev);
> -       typec->typec_cmd_supported = !!cros_ec_check_features(ec_dev, EC_FEATURE_TYPEC_CMD);
> -       typec->needs_mux_ack = !!cros_ec_check_features(ec_dev,
> -                                                       EC_FEATURE_TYPEC_MUX_REQUIRE_AP_ACK);
> +       typec->typec_cmd_supported = cros_ec_check_features(ec_dev, EC_FEATURE_TYPEC_CMD);
> +       typec->needs_mux_ack = cros_ec_check_features(ec_dev, EC_FEATURE_TYPEC_MUX_REQUIRE_AP_ACK);
>
>         ret = cros_typec_ec_command(typec, 0, EC_CMD_USB_PD_PORTS, NULL, 0,
>                                     &resp, sizeof(resp));
> --
> 2.33.0.685.g46640cef36-goog
>