linux-kernel - Re: Mapcount of subpages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24B432CB-5CBB-4309-A9D0-6E1C4395A013@nvidia.com>
Date:   Thu, 23 Sep 2021 20:25:39 -0400
From:   Zi Yan <ziy@...dia.com>
To:     Hugh Dickins <hughd@...gle.com>
Cc:     Yang Shi <shy828301@...il.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        Matthew Wilcox <willy@...radead.org>,
        Kent Overstreet <kent.overstreet@...il.com>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Darrick J. Wong" <djwong@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        David Howells <dhowells@...hat.com>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: Mapcount of subpages

On 23 Sep 2021, at 19:48, Hugh Dickins wrote:

> On Thu, 23 Sep 2021, Zi Yan wrote:
>> On 23 Sep 2021, at 17:54, Yang Shi wrote:
>>> On Thu, Sep 23, 2021 at 2:10 PM Hugh Dickins <hughd@...gle.com> wrote:
>>>>
>>>> NR_FILE_MAPPED being used for /proc/meminfo's "Mapped:" and a couple
>>>> of other such stats files, and for a reclaim heuristic in mm/vmscan.c.
>>>>
>>>> Allow ourselves more slack in NR_FILE_MAPPED accounting (either count
>>>> each pte as if it mapped the whole THP, or don't count a THP's ptes
>>>> at all - you opted for the latter in the "Mlocked:" accounting),
>>>> and I suspect subpage _mapcount could be abandoned.
>>>
>>> AFAIK, partial THP unmap may need the _mapcount information of every
>>> subpage otherwise the deferred split can't know what subpages could be
>>> freed.
>
> I believe Yang Shi is right insofar as the decision on whether it's worth
> queuing for deferred split is being done based on those subpage _mapcounts.
> That is a use I had not considered, and I've given no thought to how
> important or not it is.
>
>>
>> Could we just scan page tables of a THP during deferred split process
>> instead? Deferred split is a slow path already, so maybe it can afford
>> the extra work.
>
> But unless I misunderstand, actually carrying out the deferred split
> already unmaps, uses migration entries, and remaps the remaining ptes:
> needing no help from subpage _mapcounts to do those, and free the rest.

You are right. unmap_page() during THP split is scanning the page tables
already.

For deciding whether to queue a THP for deferred split, we probably can
keep PageDoubleMap bit to indicate if any subpage is PTE mapped.

But without subpage _mapcount, detecting extra pins to a THP before split
might be not as easy as with it. This means every THP split will need to
perform unmap_page(), then check the remaining page_count to see if
THP split is possible. That would also introduce extra system-wide overheads
from unmapping pages. Am I missing anything?


--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)