Message-ID: <874kaabdt5.fsf@intel.com>
Date:   Fri, 24 Sep 2021 11:03:34 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Doug Anderson <dianders@...omium.org>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sam Ravnborg <sam@...nborg.org>,
        "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Steev Klimaszewski <steev@...i.org>,
        "open list\:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Ripard <mripard@...nel.org>,
        Adam Ford <aford173@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Andreas Kemnade <andreas@...nade.info>,
        Andrey Zhizhikin <andrey.zhizhikin@...ca-geosystems.com>,
        Anson Huang <Anson.Huang@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Chen-Yu Tsai <wens@...e.org>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Corentin Labbe <clabbe@...libre.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Emil Velikov <emil.velikov@...labora.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        Fabio Estevam <festevam@...il.com>,
        Fabrice Gasnier <fabrice.gasnier@...com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Guido Günther <agx@...xcpu.org>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Joel Stanley <joel@....id.au>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Kees Cook <keescook@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Lionel Debieve <lionel.debieve@...com>,
        Liviu Dudau <liviu.dudau@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Martin Jücker <martin.juecker@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Michael Walle <michael@...le.cc>,
        NXP Linux Team <linux-imx@....com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Nishanth Menon <nm@...com>,
        Olivier Moysan <olivier.moysan@...com>,
        Otavio Salvador <otavio@...ystems.com.br>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Razvan Stefanescu <razvan.stefanescu@...rochip.com>,
        Robert Richter <rric@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Tony Lindgren <tony@...mide.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Will Deacon <will@...nel.org>,
        William Cohen <wcohen@...hat.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        linux-sunxi@...ts.linux.dev,
        linux-tegra <linux-tegra@...r.kernel.org>,
        Łukasz Stelmach <l.stelmach@...sung.com>,
        Stanislav Lisovskiy <stanislav.lisovskiy@...el.com>
Subject: Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding

On Mon, 20 Sep 2021, Doug Anderson <dianders@...omium.org> wrote:
> Pushed all 15 to drm-misc-next.
...
> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching
> d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from the EDID

Hi Doug, Stan's reporting "initializer element is not constant" issues
here that were discussed before [1]. I wonder what gives, you said you'd
hit them on a draft version, but not with what was merged, and I can't
reproduce this either. Curious.

BR,
Jani.


In file included from drivers/gpu/drm/drm_edid.c:42:0:
./include/drm/drm_edid.h:525:2: error: initializer element is not constant
  ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
  ^
drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro ‘drm_edid_encode_panel_id’
  .panel_id = drm_edid_encode_panel_id(vend, product_id), \
	      ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
  EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
  ^~~~~~~~~~
./include/drm/drm_edid.h:525:2: note: (near initialization for ‘edid_quirk_list[0].panel_id’)
  ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
  ^
drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro ‘drm_edid_encode_panel_id’
  .panel_id = drm_edid_encode_panel_id(vend, product_id), \
	      ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
  EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
  ^~~~~~~~~~


[1] https://lore.kernel.org/all/CAD=FV=XHvFq5+Rtax7WNq2-BieQr-BM4UnmOcma_eTzkX2ZtNA@mail.gmail.com/


-- 
Jani Nikula, Intel Open Source Graphics Center

Powered by blists - more mailing lists