linux-kernel - Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68c3f798-a18d-fe8d-2925-2686716a985b@samsung.com>
Date:   Fri, 24 Sep 2021 11:10:08 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Doug Anderson <dianders@...omium.org>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sam Ravnborg <sam@...nborg.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Ripard <mripard@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Arnd Bergmann <arnd@...db.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Emil Velikov <emil.velikov@...labora.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Russell King <linux@...linux.org.uk>,
        Will Deacon <will@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        linux-sunxi@...ts.linux.dev,
        linux-tegra <linux-tegra@...r.kernel.org>,
        Stanislav Lisovskiy <stanislav.lisovskiy@...el.com>
Subject: Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically
 instead of hardcoding

Hi

removed most cc, due to server limitation


W dniu 24.09.2021 o 10:03, Jani Nikula pisze:
> On Mon, 20 Sep 2021, Doug Anderson <dianders@...omium.org> wrote:
>> Pushed all 15 to drm-misc-next.
> ...
>> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching
>> d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from 
>> the EDID
> Hi Doug, Stan's reporting "initializer element is not constant" issues
> here that were discussed before [1]. I wonder what gives, you said you'd
> hit them on a draft version, but not with what was merged, and I can't
> reproduce this either. Curious.


Apparently this is grey area of unclear specification.

gcc version below 8 reports error, above 8.1+ should work [1]. I am not 
sure if there is nice workaround for older gcc.


[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69960#c18


Regards

Andrzej


> BR,
> Jani.
>
>
> In file included from drivers/gpu/drm/drm_edid.c:42:0:
> ./include/drm/drm_edid.h:525:2: error: initializer element is not constant
> ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
> ^
> drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro 
> ‘drm_edid_encode_panel_id’
> .panel_id = drm_edid_encode_panel_id(vend, product_id), \
> ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
> EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
> ^~~~~~~~~~
> ./include/drm/drm_edid.h:525:2: note: (near initialization for 
> ‘edid_quirk_list[0].panel_id’)
> ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
> ^
> drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro 
> ‘drm_edid_encode_panel_id’
> .panel_id = drm_edid_encode_panel_id(vend, product_id), \
> ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
> EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
> ^~~~~~~~~~
>
>
> [1] 
> https://lore.kernel.org/all/CAD=FV=XHvFq5+Rtax7WNq2-BieQr-BM4UnmOcma_eTzkX2ZtNA@mail.gmail.com/
>
>