linux-kernel - Re: [PATCH v1 2/4] mfd: arizona: Add missing entries SPI to device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210924112000.GB4840@sirena.org.uk>
Date:   Fri, 24 Sep 2021 12:20:01 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH v1 2/4] mfd: arizona: Add missing entries SPI to device
 ID table

On Fri, Sep 24, 2021 at 10:24:17AM +0100, Richard Fitzgerald wrote:
> On 23/09/2021 20:46, Mark Brown wrote:

> > Currently autoloading for SPI devices does not use the DT ID table, it uses
> > SPI modalises. Supporting OF modalises is going to be difficult if not
> > impractical, an attempt was made but has been reverted, so ensure that
> > module autoloading works for this driver by adding SPI IDs for parts that
> > only have a compatible listed.

> >   static const struct spi_device_id arizona_spi_ids[] = {
> > +	{ "wm1814", WM1814 },
> >   	{ "wm5102", WM5102 },
> >   	{ "wm5110", WM5110 },
> >   	{ "wm8280", WM8280 },
> > +	{ "wm8997", WM8997 },
> > +	{ "wm8998", WM8998 },

> WM1814, WM8997 and WM8998 do not have a SPI interface, which is why they
> aren't in the table of SPI IDs.

They're listed as valid DT compatibles for SPI so will now generate
warnings on boot, the driver should not list those compatibles if
they're not valid.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)