linux-kernel - Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9439f81a-9bcb-816e-4187-2b37a388db19@sjtu.edu.cn>
Date:   Sat, 25 Sep 2021 08:20:46 +0800
From:   Guo Zhi <qtxuning1999@...u.edu.cn>
To:     "Marciniszyn, Mike" <mike.marciniszyn@...nelisnetworks.com>,
        Bart Van Assche <bvanassche@....org>
Cc:     "Dalessandro, Dennis" <dennis.dalessandro@...nelisnetworks.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Leon Romanovsky <leon@...nel.org>,
        Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c

On 2021/9/24 22:43, Marciniszyn, Mike wrote:
>> On 9/22/21 23:45, Leon Romanovsky wrote:
>>> Isn't kptr_restrict sysctl is for that?
>> Hi Leon,
>>
>> After I sent my email I discovered the following commit: 5ead723a20e0
>> ("lib/vsprintf: no_hash_pointers prints all addresses as unhashed"; v5.12).
>> I think that commit does what we need?
>>
> Thanks Bart,
>
> I agree.
>
> Jason, as to traces, I suspect we need to do the same %p thing there for existing code and any new work.
>
> For situations for debugging in the wild, a command line arg can show the actual value.   I'm ok with that.
>
> Mike

Can this patch which changes %llx to %p in infiniband hfi1 to avoid 
kernel pointer release be applied?


Thanks.


Guo