[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CH0PR01MB7153E9B96065CEB8308816B2F2A79@CH0PR01MB7153.prod.exchangelabs.com>
Date: Mon, 27 Sep 2021 13:05:07 +0000
From: "Marciniszyn, Mike" <mike.marciniszyn@...nelisnetworks.com>
To: Guo Zhi <qtxuning1999@...u.edu.cn>,
"Dalessandro, Dennis" <dennis.dalessandro@...nelisnetworks.com>,
"dledford@...hat.com" <dledford@...hat.com>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
> Subject: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
>
> Pointers should be printed with %p or %px rather than cast to (unsigned long
> long) and printed with %llx.
> Change %llx to %p to print the pointer.
>
> Signed-off-by: Guo Zhi <qtxuning1999@...u.edu.cn>
> ---
> drivers/infiniband/hw/hfi1/ipoib_tx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> index e74ddbe4658..15b0cb0f363 100644
> --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> @@ -876,14 +876,14 @@ void hfi1_ipoib_tx_timeout(struct net_device
> *dev, unsigned int q)
> struct hfi1_ipoib_txq *txq = &priv->txqs[q];
> u64 completed = atomic64_read(&txq->complete_txreqs);
>
> - dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d
> no_desc %d ring_full %d\n",
> - (unsigned long long)txq, q,
> + dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d
> no_desc %d ring_full %d\n",
> + txq, q,
> __netif_subqueue_stopped(dev, txq->q_idx),
> atomic_read(&txq->stops),
> atomic_read(&txq->no_desc),
> atomic_read(&txq->ring_full));
> - dd_dev_info(priv->dd, "sde %llx engine %u\n",
> - (unsigned long long)txq->sde,
> + dd_dev_info(priv->dd, "sde %p engine %u\n",
> + txq->sde,
> txq->sde ? txq->sde->this_idx : 0);
> dd_dev_info(priv->dd, "flow %x\n", txq->flow.as_int);
> dd_dev_info(priv->dd, "sent %llu completed %llu used %llu\n",
> --
> 2.33.0
This patch has the correct case, but is not noted as a V2.
Jason, this one is ok.
Acked-by: Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>
Powered by blists - more mailing lists